From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 2 Mar 2007 14:04:49 -0800

> 
> The udp code is full of bad indenting, extra whitespace and other
> style confusion.  It makes no sense to declare functions that are used
> outside the current file (extern) as inline.
> 
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
> ---
>  net/ipv4/udp.c |  402 
> ++++++++++++++++++++++++++++-----------------------------
>  net/ipv6/udp.c |  175 +++++++++++++-----------
>  2 files changed, 295 insertions(+), 282 deletions(-)
> 
> --- tcp-2.6.orig/net/ipv4/udp.c       2007-03-02 12:08:06.000000000 -0800
> +++ tcp-2.6/net/ipv4/udp.c    2007-03-02 12:37:38.000000000 -0800
> @@ -120,8 +120,8 @@
>       struct hlist_node *node;
>  
>       sk_for_each(sk, node, &udptable[num & (UDP_HTABLE_SIZE - 1)])
> -             if (sk->sk_hash == num)
> -                     return 1;
> +         if (sk->sk_hash == num)
> +             return 1;

This turns tabs into spaces, it cannot be correct.

Yoshifuji fixed all the whitespace problems under net/ already
for 2.6.21
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to