On Wed, 3 Jun 2020 12:45:04 +0200 Jiri Pirko wrote: > Tue, Jun 02, 2020 at 09:33:11PM CEST, k...@kernel.org wrote: > >On Tue, 2 Jun 2020 14:31:11 +0300 Danielle Ratson wrote: > >> Currently, user has no way of knowing if a port can be split and into > >> how many ports. > >> > >> Among other things, it is currently impossible to write generic tests > >> for port split. > >> > >> In order to be able to expose the information regarding the split > >> capability to user space, set the required attributes and pass them to > >> netlink. > >> > >> Patch 1: Move set attribute from devlink_port_attrs to devlink_port. > >> Patch 2: Move switch_port attribute from devlink_port_attrs to devlink_port > >> Patch 3: Replace devlink_port_attrs_set parameters with a struct. > >> Patch 4: Set and initialize lanes attribute in the driver. > >> Patch 5: Add lanes attribute to devlink port and pass to netlink. > >> Patch 6: Set and initialize splittable attribute in the driver. > >> Patch 7: Add splittable attribute to devlink port and pass them to netlink. > >> Patch 8: Add a split port test. > > > >Since we have the splitability and number of lanes now understood by > >the core - can the code also start doing more input checking? > > Yep, that should certainly be done so some of the checks can move from > the drivers. Do you want to have this done as a part of this patchset or > a separate one?
May be a little quicker to review if everything was done in one series, but no strong feelings.
