On Tue, Mar 06, 2007 at 10:34:49AM +1100, Herbert Xu wrote: > > > > That's not true. Please see my post. > > > > Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that > > udp_recvmsg() can randomly ignore whether the HW has computed a checksum > > and compute it in SW redundantly. > > Sorry, you're right. This bug has been there for years.
Actually I think we should fix UDP regardless of whether we initialise msg_flags to zero here. It's just too error-prone to rely on it to not have MSG_TRUNC set. I'm going to clean this up for UDP and improve the UDP-lite checksum handling while I'm at it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
