Hi Hoang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on linus/master next-20200605]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Hoang-Huu-Le/tipc-update-a-binding-service-via-broadcast/20200607-122712
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2
config: um-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

cc1: warning: arch/um/include/uapi: No such file or directory 
[-Wmissing-include-dirs]
In file included from include/linux/string.h:6,
from include/uapi/linux/tipc_config.h:42,
from net/tipc/core.h:41,
from net/tipc/name_distr.c:37:
include/asm-generic/fixmap.h: In function 'fix_to_virt':
include/asm-generic/fixmap.h:32:19: warning: comparison of unsigned expression 
>= 0 is always true [-Wtype-limits]
32 |  BUILD_BUG_ON(idx >= __end_of_fixed_addresses);
|                   ^~
include/linux/compiler.h:383:9: note: in definition of macro 
'__compiletime_assert'
383 |   if (!(condition))              |         ^~~~~~~~~
include/linux/compiler.h:403:2: note: in expansion of macro 
'_compiletime_assert'
403 |  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
|  ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 
'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
|                                     ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
50 |  BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
|  ^~~~~~~~~~~~~~~~
include/asm-generic/fixmap.h:32:2: note: in expansion of macro 'BUILD_BUG_ON'
32 |  BUILD_BUG_ON(idx >= __end_of_fixed_addresses);
|  ^~~~~~~~~~~~
In file included from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:34,
from include/linux/huge_mm.h:8,
from include/linux/mm.h:675,
from net/tipc/core.h:46,
from net/tipc/name_distr.c:37:
arch/um/include/asm/uaccess.h: In function '__access_ok':
arch/um/include/asm/uaccess.h:17:29: warning: comparison of unsigned expression 
>= 0 is always true [-Wtype-limits]
17 |    (((unsigned long) (addr) >= FIXADDR_USER_START) &&          |           
                  ^~
arch/um/include/asm/uaccess.h:45:3: note: in expansion of macro 
'__access_ok_vsyscall'
45 |   __access_ok_vsyscall(addr, size) ||
|   ^~~~~~~~~~~~~~~~~~~~
net/tipc/name_distr.c: At top level:
>> net/tipc/name_distr.c:323:17: warning: no previous prototype for 
>> 'tipc_named_dequeue' [-Wmissing-prototypes]
323 | struct sk_buff *tipc_named_dequeue(struct sk_buff_head *namedq,
|                 ^~~~~~~~~~~~~~~~~~

vim +/tipc_named_dequeue +323 net/tipc/name_distr.c

   322  
 > 323  struct sk_buff *tipc_named_dequeue(struct sk_buff_head *namedq,
   324                                     u16 *rcv_nxt, bool *open)
   325  {
   326          struct sk_buff *skb, *tmp;
   327          struct tipc_msg *hdr;
   328          u16 seqno;
   329  
   330          skb_queue_walk_safe(namedq, skb, tmp) {
   331                  skb_linearize(skb);
   332                  hdr = buf_msg(skb);
   333                  seqno = msg_named_seqno(hdr);
   334                  if (msg_is_last_bulk(hdr)) {
   335                          *rcv_nxt = seqno;
   336                          *open = true;
   337                  }
   338                  if (msg_is_bulk(hdr) || msg_is_legacy(hdr)) {
   339                          __skb_unlink(skb, namedq);
   340                          return skb;
   341                  }
   342  
   343                  if (*open && (*rcv_nxt == seqno)) {
   344                          (*rcv_nxt)++;
   345                          __skb_unlink(skb, namedq);
   346                          return skb;
   347                  }
   348          }
   349          return NULL;
   350  }
   351  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to