On Tue, 23 Jun 2020 19:01:37 -0400 Michael Chan wrote:
> On older firmware, the hardware statistics are not cleared when the
> driver frees the hardware stats contexts during ifdown. The driver
> expects these stats to be cleared and saves a copy before freeing
> the stats contexts. During the next ifup, the driver will likely
> allocate the same hardware stats contexts and this will cause a big
> increase in the counters as the old counters are added back to the
> saved counters.
>
> We fix it by making an additional firmware call to clear the counters
> before freeing the hw stats contexts when the firmware is the older
> 20.x firmware.
>
> Fixes: b8875ca356f1 ("bnxt_en: Save ring statistics before reset.")
> Reported-by: Jakub Kicinski <[email protected]>
> Reviewed-by: Vasundhara Volam <[email protected]>
> Signed-off-by: Michael Chan <[email protected]>
Tested-by: Jakub Kicinski <[email protected]>
Thanks Michael!
