David Miller <[EMAIL PROTECTED]> writes: > From: Rick Jones <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 17:05:39 -0700 > > > Being paranoid - are there no worries about the alignment of dest? > > If it's an issue, it's an issue elsewhere too, as the places > where Stephen took this idiomatic code from is the code > ethernet handling and that runs on every input packet via > eth_type_trans().
As a quick note -- when you tell gcc the expected alignment by using correct types then moderm gcc should generate fast inline code for memcpy/memcmp/etc. by itself. It only falls back to a slow generic function when it cannot figure out the alignment or the size. So I expect just using u32 * instead of char * should have the same effect and would be somewhat cleaner and the memcmp could be kept. -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
