From: Samir Bellabes <[EMAIL PROTECTED]>
Date: Thu, 15 Mar 2007 02:05:53 +0100
> +#if 0
> +#define DEBUGP printk
> +#else
> +#define DEBUGP(format, args...)
> +#endif
Please no local debugging macros.
> +static unsigned int is_same_event(struct event one, struct event two) {
Please format functions properly, especially wrt. braces, they don't
belong on the line holding the argument list closing parenthesis:
return_type func_name(args)
{
}
I'm not going to read this any further, please master
Documentation/CodingStyle and resubmit if you want further
review from me.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
