>> +int aq_nic_fill_stats_data(struct aq_ring_stats_rx_s *stats_rx,
>> + struct aq_ring_stats_tx_s *stats_tx,
>> + u64 *data,
>> + unsigned int *p_count)
>> +{
>> + unsigned int count = 0U;
>> + /* This data should mimic aq_ethtool_queue_stat_names structure
>> + */
>> + data[count] += stats_rx->packets;
>> + data[++count] += stats_tx->packets;
>> + data[++count] += stats_tx->queue_restarts;
>> + data[++count] += stats_rx->jumbo_packets;
>> + data[++count] += stats_rx->lro_packets;
>> + data[++count] += stats_rx->errors;
>> + data[++count] += stats_rx->alloc_fails;
>> + data[++count] += stats_rx->skb_alloc_fails;
>> + data[++count] += stats_rx->polls;
>> +
>> + if (p_count)
>> + *p_count = ++count;
>> +
>> + return 0;
>> +}
>
> I don't see this function being taken care of in the following patch
> introducing
> the u64_stats_update_* use.
My bad, I totally missed this function somehow. Thanks for reporting.
> For review it'd be easier to get the existing problems fixed first.
> Also since this function always returns 0 please make it void.
Will do.
Best regards,
Mark.
