> -----Original Message----- > From: [email protected] <[email protected]> On > Behalf Of Jakub Kicinski > Sent: Friday, July 17, 2020 12:58 PM > To: Keller, Jacob E <[email protected]> > Cc: [email protected]; Jiri Pirko <[email protected]>; Tom Herbert > <[email protected]>; Jiri Pirko <[email protected]>; Jakub Kicinski > <[email protected]>; Jonathan Corbet <[email protected]>; Michael Chan > <[email protected]>; Bin Luo <[email protected]>; Saeed > Mahameed <[email protected]>; Leon Romanovsky <[email protected]>; > Ido Schimmel <[email protected]>; Danielle Ratson > <[email protected]> > Subject: Re: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update > library > > On Fri, 17 Jul 2020 11:35:35 -0700 Jacob Keller wrote: > > This series goal is to enable support for updating the ice hardware flash > > using the devlink flash command. > > Looks reasonable. > > You have some left over references to ignore_pending_flash_update in > comments, and you should use NLA_POLICY_RANGE() for the new attr. >
Ah, good point I'll make sure to fix those up, and switch the NLA_POLICY_RANGE. > Taking and releasing the FW lock may be fun for multi-host devices if > you ever support those. Yea. The lib/pldm stuff assumes the driver will manage the locking. I'm not sure how the resource locks work in a multi-host environment at all.. Thanks, Jake
