Hi Edward, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-2/20200730-224221 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 41d707b7332f1386642c47eb078110ca368a46f5 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/sfc/ef100_nic.c:537:3: error: 'const struct >> efx_nic_type' has no member named 'filter_rfs_expire_one' 537 | .filter_rfs_expire_one = efx_mcdi_filter_rfs_expire_one, | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/sfc/ef100_nic.c:537:27: error: initialization of 'int >> (*)(struct efx_nic *)' from incompatible pointer type 'bool (*)(struct >> efx_nic *, u32, unsigned int)' {aka '_Bool (*)(struct efx_nic *, unsigned >> int, unsigned int)'} [-Werror=incompatible-pointer-types] 537 | .filter_rfs_expire_one = efx_mcdi_filter_rfs_expire_one, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/sfc/ef100_nic.c:537:27: note: (near initialization for 'ef100_pf_nic_type.mtd_probe') cc1: some warnings being treated as errors vim +537 drivers/net/ethernet/sfc/ef100_nic.c 482 483 /* NIC level access functions 484 */ 485 #define EF100_OFFLOAD_FEATURES (NETIF_F_HW_CSUM | \ 486 NETIF_F_HIGHDMA | NETIF_F_SG | NETIF_F_FRAGLIST | \ 487 NETIF_F_TSO_ECN | NETIF_F_TSO_MANGLEID | NETIF_F_HW_VLAN_CTAG_TX) 488 489 const struct efx_nic_type ef100_pf_nic_type = { 490 .revision = EFX_REV_EF100, 491 .is_vf = false, 492 .probe = ef100_probe_pf, 493 .offload_features = EF100_OFFLOAD_FEATURES, 494 .mcdi_max_ver = 2, 495 .mcdi_request = ef100_mcdi_request, 496 .mcdi_poll_response = ef100_mcdi_poll_response, 497 .mcdi_read_response = ef100_mcdi_read_response, 498 .mcdi_poll_reboot = ef100_mcdi_poll_reboot, 499 .mcdi_reboot_detected = ef100_mcdi_reboot_detected, 500 .irq_enable_master = efx_port_dummy_op_void, 501 .irq_disable_non_ev = efx_port_dummy_op_void, 502 .push_irq_moderation = efx_channel_dummy_op_void, 503 .min_interrupt_mode = EFX_INT_MODE_MSIX, 504 .map_reset_reason = ef100_map_reset_reason, 505 .map_reset_flags = ef100_map_reset_flags, 506 .reset = ef100_reset, 507 508 .check_caps = ef100_check_caps, 509 510 .ev_probe = ef100_ev_probe, 511 .ev_init = ef100_ev_init, 512 .ev_fini = efx_mcdi_ev_fini, 513 .ev_remove = efx_mcdi_ev_remove, 514 .irq_handle_msi = ef100_msi_interrupt, 515 .ev_process = ef100_ev_process, 516 .ev_read_ack = ef100_ev_read_ack, 517 .tx_probe = ef100_tx_probe, 518 .tx_init = ef100_tx_init, 519 .tx_write = ef100_tx_write, 520 .tx_enqueue = ef100_enqueue_skb, 521 .rx_probe = efx_mcdi_rx_probe, 522 .rx_init = efx_mcdi_rx_init, 523 .rx_remove = efx_mcdi_rx_remove, 524 .rx_write = ef100_rx_write, 525 .rx_packet = __ef100_rx_packet, 526 .max_rx_ip_filters = EFX_MCDI_FILTER_TBL_ROWS, 527 .filter_table_probe = ef100_filter_table_up, 528 .filter_table_restore = efx_mcdi_filter_table_restore, 529 .filter_table_remove = ef100_filter_table_down, 530 .filter_insert = efx_mcdi_filter_insert, 531 .filter_remove_safe = efx_mcdi_filter_remove_safe, 532 .filter_get_safe = efx_mcdi_filter_get_safe, 533 .filter_clear_rx = efx_mcdi_filter_clear_rx, 534 .filter_count_rx_used = efx_mcdi_filter_count_rx_used, 535 .filter_get_rx_id_limit = efx_mcdi_filter_get_rx_id_limit, 536 .filter_get_rx_ids = efx_mcdi_filter_get_rx_ids, > 537 .filter_rfs_expire_one = efx_mcdi_filter_rfs_expire_one, 538 539 .get_phys_port_id = efx_ef100_get_phys_port_id, 540 541 .reconfigure_mac = ef100_reconfigure_mac, 542 543 /* Per-type bar/size configuration not used on ef100. Location of 544 * registers is defined by extended capabilities. 545 */ 546 .mem_bar = NULL, 547 .mem_map_size = NULL, 548 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
