Re: [PATCH v2 net-next 04/11] sfc_ef100: TX path for EF100 NICs

[Jakub Kicinski]

On Fri, 31 Jul 2020 13:59:04 +0100 Edward Cree wrote:
> +static inline efx_oword_t *ef100_tx_desc(struct efx_tx_queue *tx_queue,
> +                                      unsigned int index)

Does this static inline make any difference?

You know the general policy...

> +{
> +     if (likely(tx_queue->txd.buf.addr))
> +             return ((efx_oword_t *)tx_queue->txd.buf.addr) + index;
> +     else
> +             return NULL;
> +}