On Sat, 24 Mar 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Fri, 16 Mar 2007 20:41:02 +0200 > > > It is guaranteed to be valid only when !tp->sacked_out. In most > > cases this seqno is available in the last ACK but there is no > > guarantee for that. The new fast recovery loss marking algorithm > > needs this as entry point. > > It's a shame we keep around multiple values which represent very > related values. For example, this new seqno could be computed > using "fackets_out" if we knew also how many holes there were.
It would then be an estimate which is 100% accurate in most cases (when all related skbs are full sized). I think it must never underestimate highest_sack though, it would be quite ok to use fackets_out * mss but any > mss skb would obviously be a problem (if they ever occur)... Are all paths ok with that (this is beoynd the codepaths I'm quite sure of...)?! -- i.
