On Mon, 26 Mar 2007, Joy Latten wrote:
> Signed-off-by: Joy Latten<[EMAIL PROTECTED]>
This looks ok to me, although I have a couple of minor issues (which
should probably not stop it being merged):
> + if ((err = security_xfrm_policy_delete(pol)) != 0) {
The value of 'err' is implicitly inverted several times in this function
(and similarly in the state flush one). Something like
ret = (fn() != 0);
might be better.
> + }
> + for (i = xfrm_policy_bydst[dir].hmask; i >= 0; i--) {
Tab damage?
- James
--
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
