On 20-08-31 16:08, Andrew Lunn wrote:
> > + priv->refclk = devm_clk_get_optional(dev, NULL);
> > + if (IS_ERR(priv->refclk)) {
> > + if (PTR_ERR(priv->refclk) == -EPROBE_DEFER)
> > + return -EPROBE_DEFER;
> > +
> > + /* Clocks are optional all errors should be ignored here */
> > + return 0;
>
> Since you are calling devm_clk_get_optional() isn't an error a real
> error, not that the clock is missing? It probably should be returned
> as an error code.
Yes you're right. Actually I can't remember why went this way... I will
change this to dev_err_probe() and this gets a oneliner.
Regards,
Marco
>
> Andrew
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
