On Sun, 6 Sep 2020 03:08:45 +0000 Parav Pandit wrote:
> > >3) local: { "controller ID": x }
> > > remote1: { "controller ID": y, "external": true }
> > > remote1: { "controller ID": z, "external": true }
> > >
> > >We don't have to put the controller ID in the name for local ports, but
> > >the attribute should be reported. AFAIU name was your main concern, no?
> >
> > Okay. Sounds fine. Let's put the controller number there for all ports.
> > ctrlnum X external true
> > ctrlnum Y external false
> >
> > if (!external)
> > ignore the ctrlnum when generating the name
> >
>
> Putting little more realistic example for Jakub's and your suggestion below.
>
> Below is the output for 3 controllers. ( 2 external + 1 local )
> Each external controller consist of 2 PCI PFs for a external host via single
> PCIe cable.
> Each local controller consist of 1 PCI PF.
>
> $ devlink port show
> pci/0000:00:08.0/0: type eth netdev enp0s8f0_pf0 flavour pcipf pfnum 0 cnum 0
> external false
> pci/0000:00:08.0/1: type eth netdev enp0s8f0_c1pf0 flavour pcipf pfnum 0 cnum
> 1 external true
> pci/0000:00:08.1/1: type eth netdev enp0s8f1_c1pf1 flavour pcipf pfnum 1 cnum
> 1 external true
>
> Looks ok?
Yup, looks good, thanks.
