Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

[Andrew Lunn]

> +
> +/* 0 = Clause 22, 1 = Clause 45 */
> +#define MDIO_MODE_BIT                                BIT(8)

How about calling this MDIO_MODE_C45

> +             /* Enter Clause 45 mode */
> +             data = readl(priv->membase + MDIO_MODE_REG);
> +
> +             data |= MDIO_MODE_BIT;
> +
> +             writel(data, priv->membase + MDIO_MODE_REG);

It then becomes clearer what this does.

Otherwise this looks O.K.

          Andrew