On Thu, 8 Oct 2020 11:19:55 +0200 Linus Walleij wrote:
> diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
> index 053bf5041f8d..28f510a580be 100644
> --- a/drivers/net/dsa/rtl8366rb.c
> +++ b/drivers/net/dsa/rtl8366rb.c
> @@ -311,6 +311,13 @@
> #define RTL8366RB_GREEN_FEATURE_TX BIT(0)
> #define RTL8366RB_GREEN_FEATURE_RX BIT(2)
>
> +/**
> + * struct rtl8366rb - RTL8366RB-specific data
> + */
> +struct rtl8366rb {
> + unsigned int max_mtu[RTL8366RB_NUM_PORTS];
> +};
If you make the comment kdoc, you gotta describe all fields (or mark
'em private) otherwise:
drivers/net/dsa/rtl8366rb.c:319: warning: Function parameter or member
'max_mtu' not described in 'rtl8366rb'
