From: Vlad Yasevich <[EMAIL PROTECTED]>
Date: Mon, 23 Apr 2007 13:43:35 -0400

> [PATCH] [SCTP] Fix sctp_getsockopt_local_addrs_old() to use local storage
> 
> sctp_getsockopt_local_addrs_old() in net/sctp/socket.c calls copy_to_user()
> while the spinlock addr_lock is held. this should not be done as 
> copy_to_user()
> might sleep. the call to sctp_copy_laddrs_to_user() while holding the lock is
> also problematic as it calls copy_to_user()
> 
> Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]>

As Andrew Morton just noticed and fixed in -mm, you're passing
in int pointers to arguments that should be size_t pointers,
specifically for some of the calls to sctp_copy_laddrs().

Please fix this, and please start testing builds on 64-bit
platforms (even if via cross compile) so that you can catch
these as the warnings generated by the compiler on this one
were obvious.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to