From: David Howells <[EMAIL PROTECTED]> Date: Fri, 27 Apr 2007 15:31:40 +0100
> Fixes for various arch compilation problems: > > (*) Missing module exports. > > (*) Variable name collision when rxkad and af_rxrpc both built in > (rxrpc_debug). > > (*) Large constant representation problem (AFS_UUID_TO_UNIX_TIME). > > (*) Configuration dependencies. > > (*) printk() format warnings. > > Signed-Off-By: David Howells <[EMAIL PROTECTED]> Applied to fix the build failures, but you have to do some of this better, for example: > diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c > index 1eaf529..5ec7051 100644 > --- a/net/rxrpc/rxkad.c > +++ b/net/rxrpc/rxkad.c > @@ -18,6 +18,7 @@ > #include <linux/ctype.h> > #include <net/sock.h> > #include <net/af_rxrpc.h> > +#define rxrpc_debug rxkad_debug > #include "ar-internal.h" Please stop with this CPP macro stuff, it's really crap'ifying your otherwise quite nice code. Just use rxkad_debug in all the uses, splitting out things properly. THanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
