Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

[Boris Pismenny]

On 09/12/2020 3:11, David Ahern wrote:
> On 12/8/20 5:57 PM, David Ahern wrote:
>>> diff --git a/include/net/inet_connection_sock.h 
>>> b/include/net/inet_connection_sock.h
>>> index 7338b3865a2a..a08b85b53aa8 100644
>>> --- a/include/net/inet_connection_sock.h
>>> +++ b/include/net/inet_connection_sock.h
>>> @@ -66,6 +66,8 @@ struct inet_connection_sock_af_ops {
>>>   * @icsk_ulp_ops      Pluggable ULP control hook
>>>   * @icsk_ulp_data     ULP private data
>>>   * @icsk_clean_acked          Clean acked data hook
>>> + * @icsk_ulp_ddp_ops          Pluggable ULP direct data placement control 
>>> hook
>>> + * @icsk_ulp_ddp_data         ULP direct data placement private data
>>
>> Neither of these socket layer intrusions are needed. All references but
>> 1 -- the skbuff check -- are in the mlx5 driver. Any skb check that is
>> needed can be handled with a different setting.
> 
> missed the nvme ops for the driver to callback to the socket owner.
> 

Hopefully it is clear that these are needed, and indeed we use them in
both driver and nvme-tcp layers.