On 12/12/2020 10:20 AM, Christophe JAILLET wrote:
> If the 'register_netdev()' call fails, we must undo a previous
> 'bcmgenet_mii_init()' call.
>
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")> Signed-off-by:
> Christophe JAILLET <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
> ---
> The missing 'bcmgenet_mii_exit()' call is added here, instead of in the
> error handling path in order to avoid some goto spaghetti code.
Yes that makes sense, thanks!
--
Florian
- [PATCH] net: bcmgenet: Fix a resource leak in an e... Christophe JAILLET
- Re: [PATCH] net: bcmgenet: Fix a resource lea... Florian Fainelli
- Re: [PATCH] net: bcmgenet: Fix a resource lea... patchwork-bot+netdevbpf
