On Tue, Dec 15, 2020 at 04:01:32PM +0100, Alexandre Belloni wrote:
> Hi,
>
> On 08/12/2020 14:07:49+0200, Vladimir Oltean wrote:
> > -static int ocelot_netdevice_port_event(struct net_device *dev,
> > - unsigned long event,
> > - struct netdev_notifier_changeupper_info
> > *info)
> > +static int ocelot_netdevice_changeupper(struct net_device *dev,
> > + struct netdev_notifier_changeupper_info
> > *info)
>
> [...]
>
> > - netdev_for_each_lower_dev(dev, slave, iter) {
> > - ret = ocelot_netdevice_port_event(slave, event, info);
> > - if (ret)
> > - goto notify;
> > + netdev_for_each_lower_dev(dev, slave, iter) {
> > + ret = ocelot_netdevice_changeupper(slave,
> > event, info);
> > + if (ret)
> > + goto notify;
> > + }
> > + } else {
> > + ret = ocelot_netdevice_changeupper(dev, event, info);
>
> Does that compile?
No it doesn't.
> Shouldn't event be dropped?
It is, but in the next patch. I'll fix it, thanks.
