Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

[Joe Perches]

On Wed, 2020-12-30 at 14:07 +0800, YANG LI wrote:
> The warning was because of the following line in function
> liquidio_set_fec():
> 
> retval = wait_for_sc_completion_timeout(oct, sc, 0);
>     if (retval)
>       return (-EIO);

I presume abaci is a robot

Perhaps also the robot could look for code immediately above this like:

                oct->props[lio->ifidx].fec = var;
                if (resp->fec_setting == SEAPI_CMD_FEC_SET_RS)
                        oct->props[lio->ifidx].fec = 1;
                else
                        oct->props[lio->ifidx].fec = 0;

where a location is immediately overwritten.

so the line
                oct->props[lio->ifidx].fec = var;
could be highlighted and perhaps removed
and also perhaps the second test and set block could be written

                oct->props[lio->ifidx].fec = resp->fec_setting == 
SEAPI_CMD_FEC_SET_RS;