On Tue, 5 Jan 2021 15:43:21 +0200 Aya Levin wrote:
> There are cases where GSO segment's length exceeds the egress MTU.
Please name same for posterity.
Please widen the CC list.
> If so:
> - Consume the SKB and its segments.
> - Issue an ICMP packet with 'Packet Too Big' message containing the
> MTU, allowing the source host to reduce its Path MTU appropriately.
>
> Note: These cases are handled in the same manner in IPv4 output finish.
> This patch aligns the behavior of IPv6 and the one of IPv4.
>
> Fixes: 9e50849054a4 ("netfilter: ipv6: move POSTROUTING invocation before
> fragmentation")
Not sure if this commit actually adds the problem or just moves the
problematic snippet around. But probably doesn't matter that much for
10+ years old code.
> Signed-off-by: Aya Levin <[email protected]>
> Reviewed-by: Tariq Toukan <[email protected]>
The code itself looks reasonable AFAICT.
