On Tue, Jan 19, 2021 at 9:16 AM Rasmus Villemoes
<rasmus.villem...@prevas.dk> wrote:
>
> The two functions cpm_muram_offset() and cpm_muram_dma() both need a
> cast currently, one casts muram_vbase to do the pointer arithmetic on
> void pointers, the other casts the passed-in address u8*.
>
> It's simpler and more consistent to just always use void* and drop all
> the casting.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk>
Acked-by: Li Yang <leoyang...@nxp.com>
> ---
> drivers/soc/fsl/qe/qe_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c
> index 0fbdc965c4cb..303cc2f5eb4a 100644
> --- a/drivers/soc/fsl/qe/qe_common.c
> +++ b/drivers/soc/fsl/qe/qe_common.c
> @@ -27,7 +27,7 @@
>
> static struct gen_pool *muram_pool;
> static spinlock_t cpm_muram_lock;
> -static u8 __iomem *muram_vbase;
> +static void __iomem *muram_vbase;
> static phys_addr_t muram_pbase;
>
> struct muram_block {
> @@ -225,7 +225,7 @@ EXPORT_SYMBOL(cpm_muram_addr);
>
> unsigned long cpm_muram_offset(const void __iomem *addr)
> {
> - return addr - (void __iomem *)muram_vbase;
> + return addr - muram_vbase;
> }
> EXPORT_SYMBOL(cpm_muram_offset);
>
> @@ -235,6 +235,6 @@ EXPORT_SYMBOL(cpm_muram_offset);
> */
> dma_addr_t cpm_muram_dma(void __iomem *addr)
> {
> - return muram_pbase + ((u8 __iomem *)addr - muram_vbase);
> + return muram_pbase + (addr - muram_vbase);
> }
> EXPORT_SYMBOL(cpm_muram_dma);
> --
> 2.23.0
>
