On Mon, Jan 25, 2021 at 01:52:29PM -0800, Jakub Kicinski wrote: > On Sun, 24 Jan 2021 15:11:16 +0200 Leon Romanovsky wrote: > > +static int pci_enable_vfs_overlay(struct pci_dev *dev) { return 0; } > > +static void pci_disable_vfs_overlay(struct pci_dev *dev) {} > > s/static /static inline /
Thanks a lot, I think that we should extend checkpatch.pl to catch such mistakes. Joe, How hard is it to extend checkpatch.pl to do regexp and warn if in *.h file someone declared function with implementation but didn't add "inline" word? Thanks