On Tue, 26 Jan 2021 11:52:01 +0000 liaichun wrote:
> send_peer_notif is u8, the value of this parameter is obtained from u8*int,
> the data may be truncated.
> And in practice, more than u8(256) characters are used.
New line before Fixes
> Fixes: 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer
> notifications")
>
no new line after Fixes
> Signed-off-by: Aichun Li <[email protected]>
Please CC these folks on v2:
BONDING DRIVER
M: Jay Vosburgh <[email protected]>
M: Veaceslav Falico <[email protected]>
M: Andy Gospodarek <[email protected]>
> diff --git a/include/net/bonding.h b/include/net/bonding.h index
> 0960d9af7b8e..65394566d556 100644
> --- a/include/net/bonding.h
> +++ b/include/net/bonding.h
> @@ -215,7 +215,7 @@ struct bonding {
> */
> spinlock_t mode_lock;
> spinlock_t stats_lock;
> - u8 send_peer_notif;
> + u64 send_peer_notif;
> u8 igmp_retrans;
> #ifdef CONFIG_PROC_FS
> struct proc_dir_entry *proc_entry;
This breaks 32bit builds, as the value is used in divisions.
Please fix and resend.
