Hi Ido,
On 1/30/2021 10:42 PM, Ido Schimmel wrote:
On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
Instead of discussing it several days, maybe it's better to review
current patch, so that we can move forward :)
It took you 4 revisions to post a patch which builds cleanly and now
you want to hasten the review? My favorite kind of submission.
The mlxsw core + spectrum drivers are 65 times the size of psample
on my system. Why is the dependency a problem?
mlxsw has been using psample for ~4 years and I don't remember seeing a
single complaint about the dependency. I don't understand why this patch
is needed.
Please see Saeed's comment in previous email:
"
The issue is with distros who ship modules independently.. having a
hard dependency will make it impossible for basic mlx5_core.ko users to
load the driver when psample is not installed/loaded.
I prefer to have 0 dependency on external modules in a HW driver.
"
We are working on a tc sample offload feature for mlx5_core. The distros
are likely to request us to do this. So we address it before submitting
the driver changes.
Regards,
Chris
