On Tue, 2 Feb 2021 21:08:02 -0800 Sukadev Bhattiprolu wrote:
> Normally we clear the failover_pending flag when processing the reset.
> But if we are unable to schedule a failover reset we must clear the
> flag ourselves. We could fail to schedule the reset if we are in PROBING
> state (eg: when booting via kexec) or because we could not allocate memory.
>
> Thanks to Cris Forno for helping isolate the problem and for testing.
>
> Fixes: 1d8504937478 ("powerpc/vnic: Extend "failover pending" window")
> Signed-off-by: Sukadev Bhattiprolu <[email protected]>
> Tested-by: Cristobal Forno <[email protected]>
Applied, thanks.
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
> b/drivers/net/ethernet/ibm/ibmvnic.c
> index df1b4884b4e8..58108e1a1d2e 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -4907,7 +4907,23 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq,
> complete(&adapter->init_done);
> adapter->init_done_rc = -EIO;
> }
> - ibmvnic_reset(adapter, VNIC_RESET_FAILOVER);
> + rc = ibmvnic_reset(adapter, VNIC_RESET_FAILOVER);
> + if (rc && rc != -EBUSY) {
> + /**
I fixed this comment up for you - /** (double star) is reserved for
kdoc comments, normal comments should start with /*. And in networking
the first line of the multi-line comment is not empty.
> + * We were unable to schedule the failover
