On Fri, Feb 26, 2021 at 7:40 PM Jason A. Donenfeld <[email protected]> wrote: > > There were a few remaining tunnel drivers that didn't receive the prior > conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to > memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from > icmp{,v6}_ndo_send before sending") for details), there's even more > imperative to have these all converted. So this commit goes through the > remaining cases that I could find and does a boring translation to the > ndo variety. > > The Fixes: line below is the merge that originally added icmp{,v6}_ > ndo_send and converted the first batch of icmp{,v6}_send users. The > rationale then for the change applies equally to this patch. It's just > that these drivers were left out of the initial conversion because these > network devices are hiding in net/ rather than in drivers/net/. > > Cc: Florian Westphal <[email protected]> > Cc: Willem de Bruijn <[email protected]> > Cc: David S. Miller <[email protected]> > Cc: Hideaki YOSHIFUJI <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Steffen Klassert <[email protected]> > Fixes: 803381f9f117 ("Merge branch > 'icmp-account-for-NAT-when-sending-icmps-from-ndo-layer'") > Signed-off-by: Jason A. Donenfeld <[email protected]>
Acked-by: Willem de Bruijn <[email protected]>
