From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 5 Jun 2007 19:15:36 +0200

> I discovered one big problem with UDP binding in 2.6.22-rc4 :

Thanks for finding this problem, the crux of the issue is
INADDR_ANY.

> We really should check no socket is bound to XXX.XXX.XXX.XXX:32769. With 
> current hashing, 
> it means checking all slots in udptable[] :(
> 
> Our choices are :
> 
> 1) Drop all thoses patches and re-think them for 2.6.23 eventually
> 2) Add the extra check for ANY_ADDR sockets and perform a full scan
> 
> What do you think ?

Does checking for INADDR_ANY sockets really require a full scan?
It should just need two hash probes as far as I can tell to see
if there is "0.0.0.0:PORT" bound already.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to