On Mon, Mar 15, 2021 at 8:01 AM Alex Elder <el...@linaro.org> wrote:
>
> In review, Alexander Duyck suggested that ipa_table_hash_support()
> was trivial enough that it could be implemented as a static inline
> function in the header file. But the patch had already been
> accepted. Implement his suggestion.
>
> Signed-off-by: Alex Elder <el...@linaro.org>
Looks good to me.
Reviewed-by: Alexander Duyck <alexanderdu...@fb.com>
> ---
> drivers/net/ipa/ipa_table.c | 5 -----
> drivers/net/ipa/ipa_table.h | 5 ++++-
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c
> index baaab3dd0e63c..7450e27068f19 100644
> --- a/drivers/net/ipa/ipa_table.c
> +++ b/drivers/net/ipa/ipa_table.c
> @@ -239,11 +239,6 @@ static void ipa_table_validate_build(void)
>
> #endif /* !IPA_VALIDATE */
>
> -bool ipa_table_hash_support(struct ipa *ipa)
> -{
> - return ipa->version != IPA_VERSION_4_2;
> -}
> -
> /* Zero entry count means no table, so just return a 0 address */
> static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16
> count)
> {
> diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h
> index 1a68d20f19d6a..889c2e93b1223 100644
> --- a/drivers/net/ipa/ipa_table.h
> +++ b/drivers/net/ipa/ipa_table.h
> @@ -55,7 +55,10 @@ static inline bool ipa_filter_map_valid(struct ipa *ipa,
> u32 filter_mask)
> * ipa_table_hash_support() - Return true if hashed tables are supported
> * @ipa: IPA pointer
> */
> -bool ipa_table_hash_support(struct ipa *ipa);
> +static inline bool ipa_table_hash_support(struct ipa *ipa)
> +{
> + return ipa->version != IPA_VERSION_4_2;
> +}
>
> /**
> * ipa_table_reset() - Reset filter and route tables entries to "none"
> --
> 2.27.0
>
