On Wed, 17 Mar 2021 16:22:35 +0200 Vladimir Oltean <olte...@gmail.com> wrote:
> On Wed, Mar 17, 2021 at 02:46:41PM +0100, Marek Behún wrote: > > There are two implementations of the .set_egress_port method, and > > both of them, if successful, set chip->*gress_dest_port variable. > > > > To avoid code repetition, wrap this method into > > mv88e6xxx_set_egress_port. > > > > Signed-off-by: Marek Behún <ka...@kernel.org> > > Reviewed-by: Pavana Sharma <pavana.sha...@digi.com> > > --- > > Separately from this series, do you think you can rename the > "egress_port" into "monitor_port" across the driver? Seeing an > EGRESS_DIR_INGRESS is pretty strange. You mean even renaming methods .set_egress_port to .set_monitor_port, and type enum mv88e6xxx_egress_direction to enum mv88e6xxx_monitor_direction?
