On Thu, Jun 07, 2007 at 09:35:36PM -0400, jamal wrote: > On Thu, 2007-07-06 at 17:31 -0700, Sridhar Samudrala wrote: > > > If the QDISC_RUNNING flag guarantees that only one CPU can call > > dev->hard_start_xmit(), then why do we need to hold netif_tx_lock > > for non-LLTX drivers? > > I havent stared at other drivers, but for e1000 seems to me > even if you got rid of LLTX that netif_tx_lock is unnecessary. > Herbert?
It would guard against the poll routine which would acquire this lock when cleaning the TX ring. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
