Herbert Xu wrote: > [IPV4]: Add default config support after inetdev_init > > Previously once inetdev_init has been called on a device any changes made > to ipv4_devconf_dflt would have no effect on that device's configuration.
I noticed a few more side-effects from the original change that seem to be undesired. Some code assumes that dev->ip_ptr != NULL implies existance of IP addresses on the device. For example fib_check_nh used to allow to add routes to devices only when a in_device is present. We can now add routes without having any IP addresses configured, which makes routing choose 0.0.0.0 as source and invalidates the assumption of some other code that the outgoing device of a packet always has an in_device present (like MASQUERADE). fib_sync_up used to skip a nexthop when no IP addresses was present on the device, now it will keep it. There's probably more, I guess we need to audit all in_dev_get calls. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
