On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: > +#define ndev_err(netdev, level, format, arg...) \ > + do { \ > + struct net_device *__nd = (netdev); \ > + if ((__nd)->msg_enable & NETIF_MSG_##level) \ > + printk(KERN_ERR "%s: %s: " format, (__nd)->name, \ > + (__nd)->dev.parent->bus_id, ## arg); \ > + } while (0) > +
I think it's better to remove the macro concatenation/obfuscation of the NETIF_MSG_##level argument and simply pass the appropriate NETIF_MSG_<type> directly to these ndev_<level> calls. It would also simplify the more than 300 calls in drivers/net of if (netif_msg_<type>(ptr)) printk(foo) to ndev_<level>(netdev, NETIF_MSG_<type>, fmt, args) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html