From: Guobin Huang <huangguob...@huawei.com>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Guobin Huang <huangguob...@huawei.com>
---
 net/rfkill/input.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/rfkill/input.c b/net/rfkill/input.c
index 4b01baea1d4a..598d0a61bda7 100644
--- a/net/rfkill/input.c
+++ b/net/rfkill/input.c
@@ -36,7 +36,7 @@ module_param_named(master_switch_mode, 
rfkill_master_switch_mode, uint, 0);
 MODULE_PARM_DESC(master_switch_mode,
        "SW_RFKILL_ALL ON should: 0=do nothing (only unlock); 1=restore; 
2=unblock all");
 
-static spinlock_t rfkill_op_lock;
+static DEFINE_SPINLOCK(rfkill_op_lock);
 static bool rfkill_op_pending;
 static unsigned long rfkill_sw_pending[BITS_TO_LONGS(NUM_RFKILL_TYPES)];
 static unsigned long rfkill_sw_state[BITS_TO_LONGS(NUM_RFKILL_TYPES)];
@@ -330,8 +330,6 @@ int __init rfkill_handler_init(void)
                return -EINVAL;
        }
 
-       spin_lock_init(&rfkill_op_lock);
-
        /* Avoid delay at first schedule */
        rfkill_last_scheduled =
                        jiffies - msecs_to_jiffies(RFKILL_OPS_DELAY) - 1;

Reply via email to