Pavel Emelianov wrote: > Patrick McHardy wrote: > >>I'm going to push my latest patches to Dave today, the easiest way is >>probably is you just add whatever you need to the API afterwards. >> > > > OK. Dave didn't object against the driver. Hope he will accept it as well. > > I have also found a BUG in your API. Look, when you declare the alias with > the MODULE_ALIAS_RTNL_LINK in drivers you use strings as an argument. But > this macro stringifyes the argument itself which results in bad aliases. > > Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> > > --- > > diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h > index d744198..f627e1f 100644 > --- a/include/net/rtnetlink.h > +++ b/include/net/rtnetlink.h > @@ -77,6 +77,6 @@ extern void __rtnl_link_unregister(struc > extern int rtnl_link_register(struct rtnl_link_ops *ops); > extern void rtnl_link_unregister(struct rtnl_link_ops *ops); > > -#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" #name) > +#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" name)
Thanks, I already fixed this during final round of testing :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html