On Wed, Apr 07, 2021 at 05:21 AM CEST, Cong Wang wrote: > From: Cong Wang <[email protected]> > > Using sk_psock() to retrieve psock pointer from sock requires > RCU read lock, but we already get psock pointer before calling > ->psock_update_sk_prot() in both cases, so we can just pass it > without bothering sk_psock(). > > Reported-and-tested-by: [email protected] > Fixes: 8a59f9d1e3d4 ("sock: Introduce sk->sk_prot->psock_update_sk_prot()") > Cc: John Fastabend <[email protected]> > Cc: Eric Dumazet <[email protected]> > Cc: Daniel Borkmann <[email protected]> > Cc: Jakub Sitnicki <[email protected]> > Cc: Lorenz Bauer <[email protected]> > Signed-off-by: Cong Wang <[email protected]> > ---
We don't necessarily need to pass both sk and psock. psock has a backpointer to sk that owns it. Reviewed-by: Jakub Sitnicki <[email protected]>
