> Waskiewicz Jr, Peter P wrote: > >> > >> Looking at Peter's multiqueue patch, which should include all > >> hard_start_xmit users (I'm not seeing sch_teql though, > >> Peter?) the only other one is pktgen. > >> > > > > Ugh. That is another netif_queue_stopped() that needs > > netif_subqueue_stopped(). I can send an updated patch for > the core to > > fix this based from your patches Patrick. > > > > I still have the tree around, here's an updated version. > > > > > So what do we do about netpoll then wrt netif_(sub)queue_stopped() > > being removed from qdisc_restart()? The fallout of having > netpoll() > > cause a queue to stop (queue 0 only) is the skb sent will > be requeued, > > since the driver will return NETIF_TX_BUSY if this actually > happens. > > But this is a corner case, and we won't lose packets; we'll > just have > > increased latency on that queue. Should I worry about this or just > > move forward with the sch_teql.c change and repost the core patch? > > > > > I don't think you need to worry about that, the subqueue > patch just follows the existing code.
Thanks Patrick for taking care of this. I am totally fine with this patch; if anyone else has feedback, please send it. If not, I'm excited to see if these can be considered for 2.6.23 now. :) Thanks everyone for the help. Cheers, -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
