Francois Romieu wrote:
Jeff Garzik <[EMAIL PROTECTED]> :
Arjan van de Ven wrote:
+ pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);
can you create a pci_set_latency_timer() for this please?
[...]
+ if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
+ pci_write_config_byte(tp->pci_dev, PCI_CACHE_LINE_SIZE,
0x08);
and something for this as well?
Why? Nothing here seems generic to me.
I.e. no need for pci_set_latency_timer(struct pci_dev *dev, u8 latency)
neither pci_set_cache_line_size(struct pci_dev *dev, u8 size) ?
Yeah. When it gets to be a one-line wrapper like that, I don't see much
additional value in pci_set_cache_line_size() over
pci_write_config_byte(,PCI_CACHE_LINE_SIZE,).
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
