On Thu, 05 Jul 2007 20:11:16 +0900 Masakazu Mokuno <[EMAIL PROTECTED]> wrote:
> Hi, > > This is the third submission of the network driver for PS3. > The differences from the previous one are: > > - renamed source file names so that their prefix can match > with the module name > - added [EMAIL PROTECTED] line for MAINTAINER file > - changed some in copyright comments > > If there are no more comments, please apply for 2.6.23. > This isn't a show stopper. But could you consider integrating vlan support with existing VLAN acceleration hooks? Please remove GELIC_NET_GET_MODE/GELIC_NET_SET_MODE, they seem to be ioctl's left over from an earlier version. You don't need a net_device_stats element in gelic_net_card because it is already included in net_device structure in recent kernels. Why make ethtool support conditional. It should always be enabled. Don't call netif_poll_enable() in net_open. It is unnecessary and racy. It is better to use device name (ie eth0) as name of irq for request_irq() because the user level IRQ balancer has some heuristics that know that names of form "ethX" are network devices. May not matter on PS3 because it isn't true SMP. You are wasting memory by always allocating full maximum receive size buffers. Your max mtu is 2308 so the allocation will end up being rounded up to 4K so that costs twice as much memory as allocating a standard 1518 (or 1536) size Ethernet MTU buffer. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
