On Fri, 2007-07-13 at 14:17 +0200, Jarek Poplawski wrote:
> On Thu, Jul 12, 2007 at 08:48:45PM +0300, Ranko Zivojnovic wrote:
> ...
> > Ok - here's the patch for a review - it compiles clean ... and that's as
> > much as it has been tested - I'll try give it a run later today or
> > definitely tomorrow.
> ...
> 
> Ranko, you have some powers!
> 
> Alas, I definitely need more time. I hope I'll manage to check this
> till monday. Of course, if testing will be OK and somebody will check
> and ack this earlier I don't see any reason in waiting on my opinion.

Don't bother - just tested and it is a no-go (it would have been a
wander if it worked from the first time :)) - have to resolve the issues
with qdiscs that do not calculate/use rates...

I'm not sure if it is desirable to have rates available on all qdiscs -
even on pfifo_fast... that way, when you issue...

# tc -s qdisc show dev eth0
qdisc pfifo_fast 0: root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
 Sent 115971059 bytes 196761 pkt (dropped 0, overlimits 0 requeues 0)
 rate 0bit 0pps backlog 0b 0p requeues 0

...you will not get the 'rate 0bit'.

R.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to