Patrick McHardy wrote: > Varun Chandramohan wrote: > >> Oliver Hartkopp wrote: >> >> >>>>> I don't think you should round down timeout values. >>>>> >>>>> >>>>> >>>>> >>>> Can you elaborate on that? As per the RFC of MIB ,we need only seconds >>>> granularity. Taking that as the case i dont understand why round down >>>> should not be done? >>>> >>>> >>>> >>> When you like to create any timeout based on your calculated value, you >>> might run into the problem that your calculated value is set to _zero_ >>> even if there was "some time" before the conversion. This might probably >>> not what you indented to get. >>> >>> So what about rounding up with >>> >>> return (tv->tv_sec + (tv->tv_usec + 999999)/1000000); >>> >>> ??? >>> >>> >>> >> This can done. Is this what you were ref to me, Patrick? >> > > > Yes, timeouts should usually be at least as long as specified. > Thanks Patrick and Oliver, ill round it up. :-)
- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
