On Thu, 26 Jul 2007 02:04:31 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:

> On Thu, 26 Jul 2007 09:46:48 +0100 Stephen Hemminger <[EMAIL PROTECTED]> 
> wrote:
> 
> > Try this out:
> >      * replace macro's with inlines
> >      * get rid of places doing multiple evaluations of NODE_PARENT
> 
> And it fixes the rcu abuse which resulted in
> http://lkml.org/lkml/2007/7/25/319.  Which I assume is what inspired the
> effort.
> 
> 
> your typecasting style is inconsistent:
> 
> > +   return rcu_dereference((struct tnode *) (node->parent & 
> > ~NODE_TYPE_MASK));
> 
> space

I have a couple of followon cleanup patches, one of them is whitespace demunging
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to