>-----Original Message----- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] > >Stephen Hemminger wrote: >> Using module parameter for per device settings is bad idea. >> Please extend existing interfaces like ethtool, etc rather than >committing >> to a bad inflexible API. > > >I agreed with Stephen's comments here. > >In general, net driver policy is to use ethtool (per-interface >granularity) rather than module options. >
Thanks Stephen and Jeff for the feedback. The flow control and InterruptThrottleRate parameters were carried over from e1000 and it was pointed out to me that some disros/customer's scripts used those parameters in the scripts. Ixgbe being a new driver, we can remove those. Yes the LLI parameters can be removed. > +RxQueues > +-------- > +Valid Range: 1, 2, 4, 8 > +Default Value: 8 > + Number of RX queues. > + > + Ok. The present driver being NAPI only and supports one Rx queue only. So this parameter needs to be removed . But, once we have DaveM/Stephen work of NAPI struct work is done, driver will support multiple Rx queues and with Multi Tx queue patch already in the kernel, driver will support multiple Tx queues also shortly. So, with driver/device supporting multiple Tx and Rx queues, I think, it would be very useful to have ethtool interface to manage the number of Tx and Rx queues of the interface. Current ethtool interface supports managing the ring size so, we need similar interface for managing the number of Tx and Rx queues of the interface. Ayyappan - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
