Ramkrishna Vepa wrote:
- Added support to poll for entire set of device errors and alarms.
- Optimized interrupt routine fast path.
- Removed the unused variable, intr_type, in device private structure.

Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>

please split this patch up into multiple patches.

In general it's OK to combine several small, minor changes together, but this patch was pretty big. at that point, you need to start looking into splitting up patches into separate logical changes (intr_type clean in its own patch, irq handler optimization in its own patch, etc.).

More patches means that each patch is smaller, making it easier to review. It also means that automated tools such as git-bisect can easily identify which change created a regression, should one appear.




-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to