On Mon, 20 Aug 2007 13:45:36 +0530
Varun Chandramohan <[EMAIL PROTECTED]> wrote:
> A new function for converting timeval to time_t is added in time.h. Its a
> common function used in different
> places.
>
> Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]>
> ---
> include/linux/time.h | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/time.h b/include/linux/time.h
> index 6a5f503..1faf65c 100644
> --- a/include/linux/time.h
> +++ b/include/linux/time.h
> @@ -149,6 +149,18 @@ static inline s64 timeval_to_ns(const st
> }
>
> /**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv: pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + * Note : Here we round up the value. We dont need accuracy.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> + return (tv->tv_sec + (tv->tv_usec ? 1 : 0));
> +}
> +
Why roundup? Unless there is a requirement in the standard, please just
use the timeval seconds. In which case the inline is unneeded.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
