Hi Dave, David Miller <[EMAIL PROTECTED]> wrote on 08/22/2007 09:52:29 AM:
> From: Krishna Kumar2 <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 09:41:52 +0530 > <snip> > > > Because TSO does batching already, so it's a very good > > > "tit for tat" comparison of the new batching scheme > > > vs. an existing one. > > > > I am planning to do more testing on your suggestion over the > > weekend, but I had a comment. Are you saying that TSO and > > batching should be mutually exclusive so hardware that doesn't > > support TSO (like IB) only would benefit? > > > > But even if they can co-exist, aren't cases like sending > > multiple small skbs better handled with batching? > > I'm not making any suggestions, so don't read that into anything I've > said :-) > > I think the jury is still out, but seeing TSO perform even slightly > worse with the batching changes in place would be very worrysome. > This applies to both throughput and cpu utilization. Does turning off batching solve that problem? What I mean by that is: batching can be disabled if a TSO device is worse for some cases. Infact something that I had changed my latest code is to not enable batching in register_netdevice (in Rev4 which I am sending in a few mins), rather the user has to explicitly turn 'on' batching. Wondering if that is what you are concerned about. In any case, I will test your case on Monday (I am on vacation for next couple of days). Thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
