The following driver API is broken on any architecture with 64 bit addresses.
because of cast that loses high bits.

Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>


--- a/drivers/isdn/capi/capidrv.c       2007-06-25 09:03:12.000000000 -0700
+++ b/drivers/isdn/capi/capidrv.c       2007-08-24 11:06:46.000000000 -0700
@@ -1855,6 +1855,9 @@ static int if_sendbuf(int id, int channe
                return 0;
        }
        datahandle = nccip->datahandle;
+
+       /* This won't work on 64 bit! */
+       BUILD_BUG_ON(sizeof(skb->data) > sizeof(u32));
        capi_fill_DATA_B3_REQ(&sendcmsg, global.ap.applid, card->msgid++,
                              nccip->ncci,      /* adr */
                              (u32) skb->data,  /* Data */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to